-
Notifications
You must be signed in to change notification settings - Fork 16.4k
feat: add Yandex Cloud Lockbox secrets backend #36449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Yandex Cloud Lockbox secrets backend #36449
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
5ad5fe4 to
57d0d35
Compare
Taragolis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with with Yandex.Cloud and sdk so this is just some generic comments
57d0d35 to
158dc82
Compare
158dc82 to
b6e8787
Compare
b6e8787 to
defbc56
Compare
Piatachock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM. Mostly nit-s, endpoint parameter is important tho.
aa31fb2 to
b1ce06e
Compare
Piatachock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from Yandex
Taragolis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern about Connection ID into the Secrets Manager, see appropriate conversation
b1ce06e to
e0acf30
Compare
e0acf30 to
be6f387
Compare
|
I think it's ready to merge |
be6f387 to
2622b59
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This PR added support for Yandex Cloud Lockbox secrets backend to Yandex Cloud provider 😎
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.