Skip to content

Conversation

@romsharon98
Copy link
Contributor

@romsharon98 romsharon98 commented Dec 29, 2023

related: #36484

fix: airflow/providers/apache/hive/transfers/hive_to_samba.py

when running:
pre-commit run --files airflow/providers/apache/hive/transfers/hive_to_samba.py

before the change:

image

after the change:

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please change the title before merging :)

@romsharon98 romsharon98 changed the title Draft: Fix assignment of template field Fix assignment of template field in hive_to_samba.py Dec 29, 2023
@romsharon98 romsharon98 changed the title Fix assignment of template field in hive_to_samba.py Fix assignment of template field in __init__ in hive_to_samba.py Dec 29, 2023
@romsharon98 romsharon98 changed the title Fix assignment of template field in __init__ in hive_to_samba.py Fix assignment of template field in __init__ in hive_to_samba.py Dec 29, 2023
@eladkal eladkal merged commit 0722679 into apache:main Dec 29, 2023
@romsharon98 romsharon98 deleted the fix/hive-to-samba-operator branch December 29, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants