-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add username authenticating to the Redis hook #36562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add username authenticating to the Redis hook #36562
Conversation
We currently don't support redis 6 due to airflow/airflow/providers/redis/provider.yaml Lines 47 to 52 in dc228f9
If this is not relevant any more then we should update the provider.yaml if its still relevant than we need to handle the version support |
|
I saw this limitation, but this limitation is for the redis client library. |
cool |
6695f1b to
4423bbf
Compare
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new parameter compatible with the older versions?
|
@hussein-awala |
4423bbf to
6f64c0f
Compare
|
Indeed, I just checked and found that the username argument is accepted in the old versions. |
The two related PRs #3656i1 and apache#36562 were merged without rebasing and it caused wrong expectation in the test after username had been added in the client in one of them.
Redis 6 and above introduced an option to authenticate with username in addition to password.
This PR aims to add support for this kind of authentication.
For more info, see here