add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression #36578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
19 tasks
Lee-W
force-pushed
the
add-use-regex-to-S3KeySensor
branch
2 times, most recently
from
796494b to
ef390d8
Compare
dirrao
requested changes
Jan 4, 2024
Contributor
dirrao
left a comment
dirrao
left a comment
There was a problem hiding this comment.
It would be great if we can add the test cases for the regex.
Member
Author
Yep, will do. Thanks for suggestion 😄 |
Lee-W
force-pushed
the
add-use-regex-to-S3KeySensor
branch
from
2bce5f0 to
76eb51a
Compare
Lee-W
changed the title
Lee-W
changed the title
Lee-W
changed the title
Lee-W
force-pushed
the
add-use-regex-to-S3KeySensor
branch
2 times, most recently
from
b465528 to
c005bff
Compare
vincbeck
reviewed
Jan 8, 2024
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Looks like a cool feature users might be interested in. I think it is worth mentioning it in docs?
o-nikolas
reviewed
Jan 8, 2024
Lee-W
force-pushed
the
add-use-regex-to-S3KeySensor
branch
from
c005bff to
a459a42
Compare
dirrao
approved these changes
Jan 9, 2024
o-nikolas
approved these changes
Jan 9, 2024
vincbeck
reviewed
Jan 9, 2024
vincbeck
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.