add deferrable mode to RedshiftDataOperator #36586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
19 tasks
Lee-W
force-pushed
the
add-deferrable-mode-to-RedshiftDataOperator
branch
5 times, most recently
from
eb6277c to
d4ece3d
Compare
dirrao
requested changes
Jan 6, 2024
Contributor
dirrao
left a comment
dirrao
left a comment
There was a problem hiding this comment.
Nice work, I have given one comment. It would be great if we can add the test cases.
dirrao
requested changes
Jan 9, 2024
Contributor
dirrao
left a comment
dirrao
left a comment
There was a problem hiding this comment.
Couple of checks are failing. Can you add the units for the deferrable mode?
Member
Author
Yep, this is still a work in progress. Will try to wrap it up next week |
Lee-W
force-pushed
the
add-deferrable-mode-to-RedshiftDataOperator
branch
2 times, most recently
from
a8aa91d to
86e43e9
Compare
Lee-W
force-pushed
the
add-deferrable-mode-to-RedshiftDataOperator
branch
2 times, most recently
from
b5cb9cd to
8f59d6f
Compare
Taragolis
reviewed
Jan 16, 2024
Lee-W
force-pushed
the
add-deferrable-mode-to-RedshiftDataOperator
branch
from
6a7b3c5 to
c14e36a
Compare
syedahsn
reviewed
Jan 16, 2024
syedahsn
reviewed
Jan 16, 2024
Lee-W
force-pushed
the
add-deferrable-mode-to-RedshiftDataOperator
branch
2 times, most recently
from
18e157e to
5fe6958
Compare
Taragolis
approved these changes
Jan 17, 2024
Contributor
Taragolis
left a comment
Taragolis
left a comment
There was a problem hiding this comment.
Looks good to me, just one small nit from my side about property/cached_property
syedahsn
reviewed
Jan 17, 2024
syedahsn
reviewed
Jan 17, 2024
…s deferrable_operator fixture
Lee-W
force-pushed
the
add-deferrable-mode-to-RedshiftDataOperator
branch
from
5fe6958 to
3eea497
Compare
…_query_is_finished are implemented
Lee-W
force-pushed
the
add-deferrable-mode-to-RedshiftDataOperator
branch
from
6d94f80 to
e1e9b4f
Compare
Lee-W
force-pushed
the
add-deferrable-mode-to-RedshiftDataOperator
branch
from
e1e9b4f to
d0a7d1c
Compare
o-nikolas
approved these changes
Jan 18, 2024
eladkal
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.