-
Notifications
You must be signed in to change notification settings - Fork 16.4k
[FEAT] adds repair run functionality for databricks #36601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] adds repair run functionality for databricks #36601
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
dirrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the test cases for the new functionality?
|
sure @dirrao, adding them |
|
Hi @dirrao, added test cases to get latest repair id, I look for earlier test cases for method |
dirrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I would request data bricks expert to review this.
|
cc @alexott |
pankajastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @pankajastro , I got the issue, seems like I missed the comma in method definition |
|
Hi @pankajastro can you please review this |
|
Hi @dirrao , since repair run will work with |
|
Hi @dirrao can you please rereview |
|
hi @dirrao @pankajastro , can you please approve for CI check |
Go through the below to setup the breeze. |
dirrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @dirrao , I think CI is pending |
|
Hi @dirrao , fixed static checks, can you please run CI |
|
Still some errors :( . I recommend installing pre-commit and running |
|
sure @potiuk , doing that thanks |
|
done @potiuk |
dirrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@gaurav7261 I don't have permissions to trigger it. Let us wait for others to review and approve it. |
|
fixing ci static cheque |
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
|
Hi @Taragolis i have fixed X|Y to int | None and also fixed the change that you mentioned, thanks for that, can you reapprove |
|
I have approved ci 🤞 |
|
@pankajastro should i remove log.warn to log.info ```Check if there are no deprecate log warn...........................................Failed
airflow/providers/databricks/operators/databricks.py:93: log.warn(``` |
|
now only this error is there? |
|
@pankajastro goti it replaced log.warn from log.warning |
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
|
done @Taragolis , please trigger CI |
|
HI @pankajastro , can you trigger it, I have made changes as mentioned by @Taragolis |
|
Hi @Taragolis @pankajastro , comma miss was there |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
[FEAT] add repair run functionality in
DatabricksRunNowOperatorThis is useful in MULTI TASK mode, where operator will auto retry only failed tasks rather than relying on airflow retries that will create a new run
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.