Fix assignment of template field in __init__ in AwsToAwsBaseOperator
#36604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
approved these changes
Jan 4, 2024
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Could you check the static checks?
dirrao
requested changes
Jan 5, 2024
Contributor
dirrao
left a comment
dirrao
left a comment
There was a problem hiding this comment.
I would suggest you to configure pre-commit hook or run static checks.
https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst
romsharon98
force-pushed
the
fix/aws-to-aws-baseoperator
branch
from
5a13210 to
52773c7
Compare
Contributor
Author
Thanks @dirrao ! |
eladkal
approved these changes
Jan 5, 2024
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #36484
Add assignment in constructor.
Split one line if else statement.
cc: @shahar1
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.