Avoid using dict as default value in call_regular_interval #36608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirrao
approved these changes
Jan 5, 2024
dirrao
requested changes
Jan 5, 2024
Contributor
dirrao
left a comment
dirrao
left a comment
There was a problem hiding this comment.
Test case results are missing for failed ones. Can you rerun them?
ephraimbuddy
approved these changes
Jan 5, 2024
eladkal
approved these changes
Jan 5, 2024
Member
Author
|
I just created #36626 to add a Ruff rule to detect the usage of mutable values as argument default values. |
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit 9f275cf)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details: #36605 (review)