Fix tests to adopt changes in Jinja 3.1.3 #36731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Jan 11, 2024
eladkal
added
the
type:misc/internal
Member
|
Nice! |
Member
|
Not only fixed but future-proof. Good job on it @Taragolis |
potiuk
pushed a commit
that referenced
this pull request
Jan 13, 2024
(cherry picked from commit 8b33e25)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 15, 2024
(cherry picked from commit 8b33e25)
68 tasks
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 16, 2024
Cherry-pick changes from apache/airflow#36731 Change-Id: Idbefea8ad262c380025c81267210682d7c98eeb0 GitOrigin-RevId: 231654c0bb200f8a277324e884a66d723d94c709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently was released new version of Jinja2 (3.1.3) which seems like change some internal mechanism of load templates in
jinja2.FileSystemLoaderso our current mocking approach doesn't work anymore. This PR create templates files in temporary directory and add this directory to search pathRelated to: #36728 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.