Remove usused index on task instance #36737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts apache#30762 Index is only helpful for a user's custom query -- not for airflow in general (see comment apache#30762 (comment)). I also observed that it also takes up as much (or more) space than the table itself. As such it doesn't belong in airflow OSS.
dstandish
requested review from
XD-DENG,
ashb,
kaxil and
potiuk
as code owners
potiuk
approved these changes
Jan 11, 2024
dirrao
approved these changes
Jan 12, 2024
airflow/migrations/versions/0126_2_7_0_add_index_to_task_instance_table.py
Show resolved
Hide resolved
potiuk
pushed a commit
that referenced
this pull request
Jan 13, 2024
Index is only helpful for a user's custom query -- not for airflow in general (see comment #30762 (comment)). Noticed that this query had zero scans over a period of months. I also observed that it also takes up as much space as the table itself. Since it's not generally useful, it doesn't belong in airflow OSS. Reverts #30762 (cherry picked from commit e20b400)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 15, 2024
Index is only helpful for a user's custom query -- not for airflow in general (see comment #30762 (comment)). Noticed that this query had zero scans over a period of months. I also observed that it also takes up as much space as the table itself. Since it's not generally useful, it doesn't belong in airflow OSS. Reverts #30762 (cherry picked from commit e20b400)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30762
Index is only helpful for a user's custom query -- not for airflow in general (see comment #30762 (comment)). I also observed that it also takes up as much (or more) space than the table itself. As such it doesn't belong in airflow OSS.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.