avoid retrying after KubernetesPodOperator has been marked as failed #36749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Lee-W
force-pushed
the
fix-kpo-retry-even-after-marking-it-as-failed
branch
from
a7573f7 to
6b0f18f
Compare
dirrao
requested changes
Jan 13, 2024
Contributor
dirrao
left a comment
dirrao
left a comment
There was a problem hiding this comment.
Nice Work. It would be great if possible then, add the test cases.
Lee-W
force-pushed
the
fix-kpo-retry-even-after-marking-it-as-failed
branch
2 times, most recently
from
4f3b55b to
141b7a8
Compare
amoghrajesh
reviewed
Jan 15, 2024
Lee-W
force-pushed
the
fix-kpo-retry-even-after-marking-it-as-failed
branch
from
141b7a8 to
c10f762
Compare
amoghrajesh
approved these changes
Jan 16, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Looks good to me! Pending comments from @dirrao.
@hussein-awala WDYT?
2 tasks
dstandish
reviewed
Jan 16, 2024
dstandish
approved these changes
Jan 16, 2024
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
We should also add some test coverage to make sure we don't accidentally reintroduce this.
2 tasks
Lee-W
force-pushed
the
fix-kpo-retry-even-after-marking-it-as-failed
branch
from
b3eeab9 to
1eeeb3e
Compare
Lee-W
force-pushed
the
fix-kpo-retry-even-after-marking-it-as-failed
branch
from
1eeeb3e to
a7f25ed
Compare
jedcunningham
approved these changes
Jan 19, 2024
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
On second though, I think we are okay without test coverage on this. LGTM.
…een marked as failed apache#36471
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
if the task has been killed, do not cleanup again
Lee-W
force-pushed
the
fix-kpo-retry-even-after-marking-it-as-failed
branch
from
f7f9935 to
ca60adc
Compare
eladkal
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After marking the task as failed, KPO still has a
finallysection to run, which causes #36471. In this PR, I tried to check whetheron_killedis called and do not raise exception in thefinallysection as it'll overwrite the "Mark as failed" behavior^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.