check status before DatabricksSubmitRunOperator & DatabricksSubmitRunOperator executes in deferrable mode #36862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
Jan 18, 2024
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Left some nitpick. other looks good to me 🙂
vatsrahul1001
force-pushed
the
check-status-before-DatabricksSubmitRunOperator-execute-in-deferrable-mode
branch
2 times, most recently
from
9dea7c3 to
5a0f3b7
Compare
vatsrahul1001
force-pushed
the
check-status-before-DatabricksSubmitRunOperator-execute-in-deferrable-mode
branch
5 times, most recently
from
c36e4d4 to
3578772
Compare
Member
|
It seems there are some failed tests. Should we rebase and see whether it fixed the issue. If not, I think we'll need to take a deeper look |
vatsrahul1001
force-pushed
the
check-status-before-DatabricksSubmitRunOperator-execute-in-deferrable-mode
branch
from
3578772 to
87c2151
Compare
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
phanikumv
force-pushed
the
check-status-before-DatabricksSubmitRunOperator-execute-in-deferrable-mode
branch
from
87c2151 to
702f539
Compare
pankajastro
deleted the
check-status-before-DatabricksSubmitRunOperator-execute-in-deferrable-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses checking the status before deferring the task to the triggerer.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.