Skip to content

Conversation

@vizeit
Copy link
Contributor

@vizeit vizeit commented Jan 19, 2024


Currently configmaps are not supported in the template fields in the KubernetesPodOperator. It will be helpful to add this support to dynamically attach configmaps to a pod. This change adds support for template field for configmaps

closes: #36888

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Jan 19, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 19, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vizeit vizeit marked this pull request as draft January 19, 2024 22:04
@vizeit vizeit changed the title 36888 Template field support for configmaps Template field support for configmaps Jan 20, 2024
@vizeit vizeit changed the title Template field support for configmaps Template field support for configmaps in the KubernetesPodOperator Jan 20, 2024
@vizeit vizeit marked this pull request as ready for review January 20, 2024 05:18
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM.

@eladkal
Copy link
Contributor

eladkal commented Jan 20, 2024

We need to make sure this PR doesn't add extra work for #36484
cc @romsharon98

@romsharon98
Copy link
Contributor

We need to make sure this PR doesn't add extra work for #36484 cc @romsharon98

Checked it, looks good.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM

@hussein-awala hussein-awala requested a review from eladkal January 20, 2024 15:51
@hussein-awala hussein-awala merged commit 43d1925 into apache:main Jan 20, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 20, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for configmaps (as env var & volume) in the template fields in the KubernetesPodOperator

5 participants