Skip to content

[AIRFLOW-2860] Update tests for druid hook #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bolkedebruin merged 2 commits into from
Aug 7, 2018
Merged

[AIRFLOW-2860] Update tests for druid hook #3710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d1fd50
[AIRFLOW-2860] Update tests for druid hook
awelsh93 Aug 6, 2018
1a8abf1
[AIRFLOW-2860] Raise ValueError if timeout < 1 in druid hook
awelsh93 Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion airflow/hooks/druid_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class DruidHook(BaseHook):
which accepts index jobs
:type druid_ingest_conn_id: string
:param timeout: The interval between polling
the Druid job for the status of the ingestion job
the Druid job for the status of the ingestion job.
Must be greater than or equal to 1
:type timeout: int
:param max_ingestion_time: The maximum ingestion time before assuming the job failed
:type max_ingestion_time: int
Expand All @@ -53,6 +54,9 @@ def __init__(
self.max_ingestion_time = max_ingestion_time
self.header = {'content-type': 'application/json'}

if self.timeout < 1:
raise ValueError("Druid timeout should be equal or greater than 1")

def get_conn_url(self):
conn = self.get_connection(self.druid_ingest_conn_id)
host = conn.host
Expand Down
4 changes: 2 additions & 2 deletions tests/hooks/test_druid_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def test_submit_unknown_response(self, m):

@requests_mock.mock()
def test_submit_timeout(self, m):
self.db_hook.timeout = 0
self.db_hook.timeout = 1
self.db_hook.max_ingestion_time = 5
task_post = m.post(
'http://druid-overlord:8081/druid/indexer/v1/task',
Expand Down Expand Up @@ -131,7 +131,7 @@ def test_get_conn_url(self, mock_get_connection):
get_conn_value.port = '1'
get_conn_value.extra_dejson = {'endpoint': 'ingest'}
mock_get_connection.return_value = get_conn_value
hook = DruidHook(timeout=0, max_ingestion_time=5)
hook = DruidHook(timeout=1, max_ingestion_time=5)
self.assertEquals(hook.get_conn_url(), 'https://test_host:1/ingest')


Expand Down