Skip to content

Conversation

@mattiabertorello
Copy link
Contributor

Currently, a lineage backend has difficulty distinguishing between job types Spark, DBT, and Airflow and needs regex on the _producer to get this information.
We need to add the JobType that is supported in the OpenLineage specification to fix the issue.

These changes are the same as done in the PR #2412. Open the OpenLineage repository for an older version of Airflow.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 8, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@mobuchowski mobuchowski self-requested a review February 8, 2024 18:12
@mattiabertorello mattiabertorello force-pushed the openlineage/add-job-facet branch 5 times, most recently from f68ba0d to eb8ba18 Compare February 13, 2024 15:45
@mattiabertorello mattiabertorello force-pushed the openlineage/add-job-facet branch 2 times, most recently from 813d1cd to 1cdfc3d Compare February 14, 2024 15:58
Signed-off-by: Mattia Bertorello <mattia.bertorello@booking.com>
Signed-off-by: Mattia Bertorello <mattia.bertorello@booking.com>
@mattiabertorello mattiabertorello force-pushed the openlineage/add-job-facet branch from 1cdfc3d to f346c15 Compare February 15, 2024 12:09
@mobuchowski mobuchowski merged commit 1851a71 into apache:main Feb 19, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 19, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@mattiabertorello mattiabertorello deleted the openlineage/add-job-facet branch March 18, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants