-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Pinecone provider support for pinecone-client>=3
#37307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dirrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it backward compatible? Does it break during upgrade?
If so, it's worth to mention the same in the release notes about this breaking change.
Difficult to say right now, in general bump dependency version is not a breaking changes, if all other components remain unchanged or compatible. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
…37158-pinecone-3.x
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
…37158-pinecone-3.x
|
@sunank200 , @Lee-W, Do you have any more feedback for the PR? |
…37158-pinecone-3.x Signed-off-by: kalyanr <kalyan.ben10@live.com>
…37158-pinecone-3.x
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes: #37158
Adds support for pinecone-client >= 3.x
Migration checks
list_indexesandlist_collectionsdescribe_indexresponse changequerymethod.querieskeyword inquerymethodscale_indexPINECONE_DEBUG_CURLsupport for debug logsAdditional tasks: