fix: Signature of "insert_rows" incompatible with supertype "DbApiHook" #37391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following mypy check failure for the google provider.
in DbApiHook--> insert_rows method was recently updated to include executemany parameter. But, Google provider --> BigQueryHook inherits the DbApiHook. Is it necessary that insert_rows (link to the def) defined in an inherited class to have same signature? I've been seeing the following error locally and am wondering if BigQueryHook also needs to include the newly added executemany parameter
Related slack chat: https://apache-airflow.slack.com/archives/CCPRP7943/p1707836093751379