Skip to content

Conversation

@Taragolis
Copy link
Contributor

I can't find any reference to markdown in Airflow codebase

grep -inr --include \*.py 'from markdown ' airflowgrep -inr --include \*.py 'import markdown ' airflowgrep -inr --include \*.py 'import markdown' airflow
airflow/www/utils.py:34:from markdown_it import MarkdownItgrep -inr --include \*.py 'from markdown' airflow
airflow/www/utils.py:34:from markdown_it import MarkdownI

Seems like it is stale dependencies from time when we switch to markdown-it-py library: #19702


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels Feb 13, 2024
@Taragolis
Copy link
Contributor Author

I guess it should be remaining in constraints, because markdown is dependency for apprise which is dependency for apache-airflow-providers-apprise

@potiuk
Copy link
Member

potiuk commented Feb 13, 2024

I guess it should be remaining in constraints, because markdown is dependency for apprise which is dependency for apache-airflow-providers-apprise

Ah yeah - then there is no need to change EPOCH, this will also be nicer for the cache if we do not change it.

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@potiuk potiuk merged commit 8b6f448 into apache:main Feb 13, 2024
@potiuk potiuk added this to the Airflow 2.8.2 milestone Feb 13, 2024
@Taragolis Taragolis deleted the remove-markdown-dependency branch February 13, 2024 23:35
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Feb 19, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 20, 2024
* Remove `markdown` from core dependencies

* Apply suggestions from code review

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
(cherry picked from commit 8b6f448)
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
* Remove `markdown` from core dependencies

* Apply suggestions from code review

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
(cherry picked from commit 8b6f448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants