Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Feb 13, 2024

It's been impossible to test canary runs as they are only run when you push to main or one of the v2-*-test branch in apache/airlfow repo. This PR adds capability to run special PR with canary label to test canary run workflow in a PR from committer run in the apache/airflow repo.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

It's been impossible to test canary runs as they are only run when
you push to `main` or one of the `v2-*-test` branch in apache/airlfow
repo. This PR adds capability to run special PR with `canary` label
to test canary run workflow in a PR from committer run in the
apache/airflow repo.
@potiuk potiuk added the canary When set on PR running from apache repo - behave as canary run label Feb 13, 2024
@potiuk potiuk changed the title Add capability of testin canary CI runs by apache/airflow PR Add capability of testing canary CI runs by apache/airflow PR Feb 13, 2024
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
Copy link
Member Author

potiuk commented Feb 13, 2024

Also that's a nice way to refresh constraints and cache it turns out. I have sometimes problems with main canary build to succeed because subsequent merges to main will cancel running canary builds, so if there are merges happening every 20/30 minutes it prevents the cache from being refreshed and constraints from being updated, But this one should nicely allow doing that by opening a canary PR :)

@potiuk potiuk merged commit 326a77a into main Feb 13, 2024
potiuk added a commit that referenced this pull request Feb 14, 2024
Follow up after #37406 - we could not test this change as there
was no way to test canary builds but as the capability has been
added in #37408 we can fix the failure and actually test it in
a "canary" PR.
potiuk added a commit that referenced this pull request Feb 14, 2024
Follow up after #37406 - we could not test this change as there
was no way to test canary builds but as the capability has been
added in #37408 we can fix the failure and actually test it in
a "canary" PR.
@Taragolis Taragolis deleted the add-capability-of-testing-canary-runs-in-prs branch April 3, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools canary When set on PR running from apache repo - behave as canary run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants