Add support for impersonation chain to GKEStartPodOperator in deferrable mode #37486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We utilize the existing implementation of `_CredentialsToken` by using the async hook's `get_token` method. This implementation allows us to leverage several features of the Google connection from `Keyfile Path` or `Keyfile JSON` (see apache#37081) to impersonation chain on hook or connection level. We therefore do not need to rely on the async hook's `service_file_as_context` method, which does not support impersonation chain. With this change we effectively gain support for impersonation chain in GKEStartPodOperator in deferrable mode.
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
m1racoli
changed the title
Lee-W
reviewed
Feb 18, 2024
potiuk
approved these changes
Feb 21, 2024
Member
|
LGTM: @Lee-W ? |
79 tasks
|
Hello! Is there any reason to not also add such mechanism for the equivalent GKEStartJobOperator? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We utilize the existing implementation of
_CredentialsTokenby using the async hook'sget_tokenmethod. This implementation allows us to leverage several features of the Google connection fromKeyfile PathorKeyfile JSON(see #37081) to impersonation chain on hook or connection level. We therefore do not need to rely on the async hook'sservice_file_as_contextmethod, which does not support impersonation chain.With this change we effectively gain support for impersonation chain in GKEStartPodOperator in deferrable mode.
related: #37081
Adding @Lee-W for visibility.