Fix KPO task hanging when pod fails to start within specified timeout #37514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
I am observing an issue wrt to the recent deferrable KPO changes in PR apache#37279 and apache#37454, where when the pod fails to start within a specified timeout value, the KPO task is hanging forever whereas it is expected to fail after the timeout. This PR fixes the issue by correcting a logical error for detecting if elapsed timeout has occured for raising the timeout trigger event.
pankajkoti
force-pushed
the
fix-kpo-start-timeout-task-fail
branch
from
470a2fa to
0bccabb
Compare
pankajkoti
commented
Feb 18, 2024
pankajkoti
commented
Feb 18, 2024
pankajastro
approved these changes
Feb 18, 2024
1 task
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am observing an issue wrt to the recent deferrable KPO
changes in PR #37279 and #37454,
where when the pod fails to start within a specified timeout value,
the KPO task is hanging forever whereas it is expected to fail after the
timeout. This PR fixes the issue by correcting a logical error for
detecting if elapsed timeout has occurred for raising the timeout
trigger event.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.