fix: use offset-naive datetime in _CredentialsToken #37539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
The field `access_token_acquired_at` is specific to gcloud-aio's Token class and will be used on subsequent calls of `get` with an offset-naive datetime insternally. Therefore we cannot use offset-aware instances of datetime here.
m1racoli
force-pushed
the
fix-acquire-access-token
branch
from
9c45881 to
08ab9ec
Compare
Taragolis
reviewed
Feb 19, 2024
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
Let others know about things to consider when upgrading the major version of gcloud-aio-auth.
Taragolis
approved these changes
Feb 19, 2024
dirrao
approved these changes
Feb 20, 2024
eladkal
reviewed
Feb 20, 2024
| - apache-airflow>=2.6.0 | ||
| - apache-airflow-providers-common-sql>=1.7.2 | ||
| - asgiref>=3.5.2 | ||
| # When upgrading the major version of gcloud-aio-auth we want to make sure to |
Contributor
There was a problem hiding this comment.
Is something block us from upgrading version now?
Contributor
Author
There was a problem hiding this comment.
Generally speaking, no. I suppose a bit more care is needed when doing so, as it affects a range of async code of the provider. Also not sure yet how it affects the other gcloud-aio packages.
79 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field
access_token_acquired_atis specific to gcloud-aio's Token class and will be used on subsequent calls ofgetwith an offset-naive datetime insternally. Therefore we cannot use offset-aware instances of datetime here.related: #37138
@Taragolis
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.