Implement filter_permitted_menu_items in AWS auth manager
#37627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
force-pushed
the
vincbeck/batch_menu
branch
from
42a453a to
387b9d0
Compare
vincbeck
requested review from
ashb,
bbovenzi,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
o-nikolas
approved these changes
Feb 23, 2024
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
Just some minor comments
potiuk
reviewed
Feb 23, 2024
Co-authored-by: Niko Oliveira <onikolas@amazon.com>
vincbeck
changed the title
get_permitted_menu_items in AWS auth managerfilter_permitted_menu_items in AWS auth manager
potiuk
approved these changes
Feb 23, 2024
79 tasks
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
filter_permitted_menu_itemsin AWS auth manager. This allows optimization on menu generation. Instead of making one call for each menu item, we do one for the entire menu.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.