Skip to content

Protect against the case where Airflow is checked out in AIRFLOW_HOME #37697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Feb 26, 2024
Merged

Protect against the case where Airflow is checked out in AIRFLOW_HOME #37697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion dev/breeze/src/airflow_breeze/utils/path_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,17 @@ def find_airflow_sources_root_to_operate_on() -> Path:
# only print warning and sleep if not producing complete results
reinstall_if_different_sources(airflow_sources)
reinstall_if_setup_changed()
os.chdir(str(airflow_sources))
os.chdir(airflow_sources.as_posix())
airflow_home_dir = Path(os.environ.get("AIRFLOW_HOME", (Path.home() / "airflow").resolve().as_posix()))
if airflow_sources.resolve() == airflow_home_dir.resolve():
get_console().print(
f"\n[error]Your Airflow sources are checked out in {airflow_home_dir} which "
f"is your also your AIRFLOW_HOME where airflow writes logs and database. \n"
f"This is a bad idea because Airflow might override and cleanup your checked out "
f"sources and .git repository.[/]\n"
)
get_console().print("\nPlease check out your Airflow code elsewhere.\n")
sys.exit(1)
return airflow_sources


Expand Down