Remove SMTP provider settings from the core settings #37710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ups. So that is even worse because smtp 1.6.0 does not work even for 2.8.2 and 2.8.1 - so we shoudl rather downgrade it in constraints (and re-generate image to 1.5.0) |
potiuk
approved these changes
Feb 26, 2024
Contributor
Author
|
Oh "MyPy checks" failed, I've forgot that it should be required to make this changes first into the provider 🤦 |
Contributor
Author
Maybe we also mark release 1.6.0 as yanked and make 1.6.1 with fixes? |
Member
Yep. I proposed it in |
potiuk
added a commit
that referenced
this pull request
Feb 26, 2024
potiuk
added a commit
that referenced
this pull request
Feb 26, 2024
Contributor
Author
|
Closed in favor of #37711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #37703
This settings only will be added into the Airflow 2.9 for avoid the situation with future deprecation this attribute better just remove it now.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.