Add REST API events to Audit Log #37734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
XD-DENG,
ashb,
ephraimbuddy,
kaxil,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
Closed
airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py
Outdated
Show resolved
Hide resolved
airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py
Outdated
Show resolved
Hide resolved
bbovenzi
changed the title
jscheffl
approved these changes
Feb 29, 2024
airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py
Outdated
Show resolved
Hide resolved
Lee-W
force-pushed
the
audit-rest-api-crud
branch
2 times, most recently
from
07e54dc to
68a655a
Compare
Member
|
@bbovenzi |
Lee-W
force-pushed
the
audit-rest-api-crud
branch
2 times, most recently
from
96419d8 to
77249b2
Compare
…ng_size.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
bbovenzi
force-pushed
the
audit-rest-api-crud
branch
from
77249b2 to
8c258be
Compare
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
Can we add a newfragment that documents the event changes that happen as a result of this?
jedcunningham
approved these changes
Mar 7, 2024
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22352
Add logging to all CRUD REST API endpoints. In the
action_loggingdecorator, include checks for the url and origin to also distinguish between API endpoints from the Airflow UI vs externally.api.{name_of_function}orui.{name_of_function}^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.