Unify aws_conn_id type to always be str | None #37768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
eejbyfeldt
force-pushed
the
unify-aws-conn-id-type
branch
from
3a06e93 to
8ebac36
Compare
Taragolis
approved these changes
Feb 28, 2024
Contributor
|
Really nice |
79 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the
AwsHooks support passingNoneforaws_conn_idmeaning that is should use the default boto3 behavior for deriving credentials. But in lots of operators theaws_conn_idtype is typed as onlystrthis leads to type errors in users code if they pass None toaws_conn_ideven though this is supported in practice.This PR resolves this by updating the all (maybe just most) type annotations for
aws_conn_idto bestr | Noneinstead of juststr.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.