[AIRFLOW-2947] Added Helm chart for Kubernetes executor #3792
Conversation
|
This is a -1 from me - I don't like Helm's requirement to be run as an all-powerful user in the cluster. |
|
@ashb That's not a hard-requirement from Helm, it's completely possible to deploy Tiller in a namespace with only access to that namespace. |
|
I'm also not a fan of that model as it's a resource hog ;) |
|
@ashb I agree that helms super-user tiller is a really bad security model
but there are best practices users can take to use it safely. It's also the
lowest barrier to entry and a lot of people in the k8s world have been
asking for a chart.
Also worth mentioning that helm 3 will completely remove the tiller.
https://sweetcode.io/a-first-look-at-the-helm-3-plan/
…On Thu, Aug 23, 2018, 7:47 AM Jon Davies ***@***.***> wrote:
@ashb <https://github.com/ashb> That's not a hard-requirement from Helm,
it's completely possible to deploy Tiller in a namespace.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3792 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AChYgsxKegZIbqb6-BBl5uifFfH-C7nAks5uTsCTgaJpZM4WJq3k>
.
|
|
Yeah, I'm waiting quite eagerly for Helm3. I'm not a fan of this right now, but I also don't feel that strongly about it, certainly not enough to veto or anything like that. |
|
I think we're in a similar mind about the current state of helm. I think
this'll be useful for people wanting to test airflow out or build quick
POCs, but hopefully for production they use something like the airflow
operator.
…On Thu, Aug 23, 2018, 8:05 AM Ash Berlin-Taylor ***@***.***> wrote:
Yeah, I'm waiting quite eagerly for Helm3. I'm not a fan of this right
now, but I also don't feel that strongly about it, certainly not enough to
veto or anything like that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3792 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AChYgqjw1X0DXt0xNZLR6mQF4VPiMBu1ks5uTsTHgaJpZM4WJq3k>
.
|
|
@ashb I do not see what your remark has to do with Airflow, to what I see and use in other charts in this repository, they almost all follow the same structure, and this airflow chart looks like every other. If you want to deploy this chart without Tiller, you can do |
|
@jpds It looks like you removed the kube/deploy folder but it's not removed from the setup_kubernetes script https://github.com/apache/incubator-airflow/blob/5bd5a7bad638241c01ac1ddd0fe8f8c7a3e95d27/scripts/ci/kubernetes/setup_kubernetes.sh. It looks like this PR has screwed up the kubernetes tests and now they're just running the normal airflow tests. https://travis-ci.org/apache/incubator-airflow/jobs/419688983 |
|
Wait. No. This is on the master branch. Thats... not good. Going to investigate further. |
|
Ok so that was caused by the recent dockerized ci pipeline. I'm addressing the issue here #3797 |
|
Lol so now that the tests have been fixed, let's revisit this :). @jpds could you please rebase? |
|
@jpds ping |
|
@jpds could you please rebase this? Would love to start offering this as a simple solution for testing out the k8sExecutor :). |
|
@jpds Still interested in this feature as i might be interested to take over if you dont ? |
|
@gauthiermartin I think it's safe at this point to take over this effort since it's been a few months. |
|
@jpds I'm going to close this PR as stale. Please let me know if you want me to reopen it. |
6 participants
Jira
Description
Added Helm chart for Airflow.
Tests
This probably should run helm lint, happy to add it if someone can show me how to integrate it into Travis CI.
Commits