Skip to content

[AIRFLOW-2949] Add syntax highlight for single quote strings #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feng-tao merged 2 commits into from
Aug 29, 2018
Merged

[AIRFLOW-2949] Add syntax highlight for single quote strings #3795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4f8042
AIRFLOW-2949: Add syntax highlight for single quote strings
tzulberti-jampp Aug 23, 2018
6e6fc26
AIRFLOW-2949: Also updated new UI main.css
tzulberti-jampp Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow/www/static/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,3 +262,4 @@ div.square {
.sc { color: #BA2121 } /* Literal.String.Char */
.sd { color: #BA2121; font-style: italic } /* Literal.String.Doc */
.s2 { color: #BA2121 } /* Literal.String.Double */
.s1 { color: #BA2121 } /* Literal.String.Single */
Copy link
Member

@feng-tao feng-tao Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we are about to retire old UI, do you want to modify the new rbac UI(www_rbac). FYI, the new UI is managed by npm, so I assume you need to modify the npm package?

Copy link
Contributor Author

@tzulberti-jampp tzulberti-jampp Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the last commit, I added to the main.css inside the wwr_rbac. I am still missing something?

Copy link
Member

@feng-tao feng-tao Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay. LGTM.

1 change: 1 addition & 0 deletions airflow/www_rbac/static/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,4 @@ div.square {
.sc { color: #BA2121 } /* Literal.String.Char */
.sd { color: #BA2121; font-style: italic } /* Literal.String.Doc */
.s2 { color: #BA2121 } /* Literal.String.Double */
.s1 { color: #BA2121 } /* Literal.String.Single */