Fix a bug where scheduler heartrate parameter were not used #37992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
2 tasks
ephraimbuddy
approved these changes
Mar 8, 2024
dirrao
reviewed
Mar 8, 2024
potiuk
force-pushed
the
fix-heartrate-for-scheduler
branch
from
39ecd33 to
4ef00bd
Compare
Member
Author
|
I actually tracked it down wrongly - it's there since 2.6.0 and #30255 |
Sinc apache#30255 scheduler heartrate has not been properly calculated. We missed the check for SchedulerJob type and setting heartrate value from `scheduler_health_check_threshold`. This PR fixes it. Fix: apache#37971
potiuk
force-pushed
the
fix-heartrate-for-scheduler
branch
from
4ef00bd to
4af9e20
Compare
eladkal
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #30255 scheduler heartrate has not been properly calculated. We missed the check for SchedulerJob type and setting heartrate value from
scheduler_health_check_threshold.This PR fixes it.
Fix: #37971
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.