Fix bug in validate-operators-init pre-commit #38014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahar1
force-pushed
the
validate-operators-init-fix
branch
from
f4247a6 to
47d477b
Compare
eladkal
approved these changes
Mar 9, 2024
Contributor
|
It looks like more files are failing on the test |
shahar1
force-pushed
the
validate-operators-init-fix
branch
from
47d477b to
af93ceb
Compare
shahar1
force-pushed
the
validate-operators-init-fix
branch
from
af93ceb to
38782ec
Compare
Contributor
Author
Fixed, should be ok now |
potiuk
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #36484,
Unfortunately, in PR #33786, I accidentally missed a condition to check that templated fields' assigned values are parameters with the same name. This PR fixes the pre-commit while ignoring 6 files in
.pre-commit-configthat currently do not comply with this requirement.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.