Skip to content

Conversation

@bbovenzi
Copy link
Contributor

Fixes: #38030


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.9.0 milestone Mar 12, 2024
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 12, 2024
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Mar 13, 2024
@potiuk
Copy link
Member

potiuk commented Mar 13, 2024

Breeze importlib-resources test failure fixed in main. Merging.

@potiuk potiuk merged commit 43d7f6d into apache:main Mar 13, 2024
drajguru pushed a commit to drajguru/airflow that referenced this pull request Mar 14, 2024
@Pad71
Copy link

Pad71 commented Mar 14, 2024

Hi. @bbovenzi , @potiuk I looked at the code in the commit and it seems to me that the "root" part of the link is omitted in the url_root.

Old one:
url_root = url_for(
"Airflow.graph", dag_id=dag_id, root=task_id, execution_date=execution_date.isoformat()
)

New one:
url_root = url_for(
"Airflow.grid",
dag_id=dag_id,
task_id=task_id,
dag_run_id=run_id,
tab="graph",
map_index=attr.get("map_index", -1),
)

There is no root in the new one. I think, the "root" filtering (very helpful in large Dags) should remain, only "task_id" should be added.

@potiuk potiuk modified the milestones: Airflow 2.9.0, Airflow 2.8.4 Mar 18, 2024
@jedcunningham jedcunningham deleted the fix-taskinstance-list-link branch March 18, 2024 20:41
jedcunningham added a commit to astronomer/airflow that referenced this pull request Mar 18, 2024
We have links to the graph, filtered down to a specific TI. This was
accidentally broken in apache#38096.
@jedcunningham
Copy link
Member

Thanks @Pad71, opened #38274 to fix it.

jedcunningham added a commit that referenced this pull request Mar 18, 2024
We have links to the graph, filtered down to a specific TI. This was
accidentally broken in #38096.
jedcunningham pushed a commit that referenced this pull request Mar 18, 2024
jedcunningham added a commit that referenced this pull request Mar 18, 2024
We have links to the graph, filtered down to a specific TI. This was
accidentally broken in #38096.

(cherry picked from commit 8ea95e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect link to task detail from task instance list

7 participants