Fix excessive permission changing for log task handler #38164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
reviewed
Mar 14, 2024
Taragolis
reviewed
Mar 14, 2024
potiuk
force-pushed
the
fix-changing-permission-for-home-dir
branch
3 times, most recently
from
6a27f80 to
94b5f78
Compare
When log dir permission was changed by log handler, we've implemented also changing permissions of parent folders recursively, however it was quite a bit too much to change it for home directory where the log folder could have been created - because in some cases changing permissions might lead to unexpected side-effects - such as loosing ability to login to ssh server. Fixes: apache#38137
potiuk
force-pushed
the
fix-changing-permission-for-home-dir
branch
from
94b5f78 to
ab817df
Compare
Member
Author
|
Implemented way better (and simpler) fix |
potiuk
changed the title
Taragolis
approved these changes
Mar 18, 2024
jedcunningham
pushed a commit
that referenced
this pull request
Mar 18, 2024
When log dir permission was changed by log handler, we've implemented also changing permissions of parent folders recursively, however it was quite a bit too much to change it for home directory where the log folder could have been created - because in some cases changing permissions might lead to unexpected side-effects - such as loosing ability to login to ssh server. Fixes: #38137 (cherry picked from commit 2c1d0f8)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When log dir permission was changed by log handler, we've implemented also changing permissions of parent folders recursively, however it was quite a bit too much to change it for home directory where the log folder could have been created - because in some cases changing permissions might lead to unexpected side-effects - such as loosing ability to login to ssh server.
Fixes: #38137
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.