Skip to content

Conversation

@raphaelauv
Copy link
Contributor

@raphaelauv raphaelauv commented Mar 15, 2024

fix: #38176

@raphaelauv raphaelauv marked this pull request as draft March 15, 2024 11:45
@raphaelauv raphaelauv force-pushed the fix/dag_run_dag_id_execution_date_key branch from e603d99 to 9faa166 Compare March 15, 2024 12:19
@raphaelauv raphaelauv force-pushed the fix/dag_run_dag_id_execution_date_key branch from 9faa166 to 19dc6cb Compare March 15, 2024 12:33
Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For avoid accidentally merge

This was discussed into the Dev List into the past, there is no consensus about this remove uniques of execution date, see:
[DISCUSS] Allowing Multiple DAG Runs with the Same Execution Date

So I would rather create a new discussion in dev list first

@hussein-awala
Copy link
Member

I was actively working on this, but found some tables that only use execution date as the primary key (without dag run id), so we need to migrate them first before removing the unique constraint on execution date. I will create an issue with all the details in the coming weeks.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 30, 2024
@github-actions github-actions bot closed this May 5, 2024
@raphaelauv raphaelauv deleted the fix/dag_run_dag_id_execution_date_key branch September 4, 2024 14:03
@raphaelauv
Copy link
Contributor Author

#41818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

constraint "dag_run_dag_id_execution_date_key" not using run_id

3 participants