retrieve dataset event created through RESTful API when creating dag run #38332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
Lee-W
force-pushed
the
fix-missing-rest-api-dataset-event-in-grid-view
branch
2 times, most recently
from
b003eda to
0418797
Compare
Lee-W
changed the title
Lee-W
force-pushed
the
fix-missing-rest-api-dataset-event-in-grid-view
branch
from
47d9c09 to
b2de05f
Compare
phanikumv
requested review from
bbovenzi,
pankajastro,
pankajkoti and
sunank200
…I when creating dag run currently dataset event created throught RESTful API will be ignored as there's no source_dag_run atttribute
phanikumv
force-pushed
the
fix-missing-rest-api-dataset-event-in-grid-view
branch
from
b2de05f to
3927339
Compare
jedcunningham
approved these changes
Mar 21, 2024
phanikumv
approved these changes
Mar 21, 2024
pankajkoti
reviewed
Mar 21, 2024
pankajkoti
approved these changes
Mar 21, 2024
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#37570 introduces an API endpoint for users to create a dataset event. However, these dataset events are not shown in
Detailson the web UIWhat
This PR modifies the following to include the Dataset Events that do not have a
source_dag_runattribute (created through RESTful API)airflow/airflow/jobs/scheduler_job_runner.py
Lines 1267 to 1275 in 1a9b71a
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.