Exit with error in case dependencies are not synchronized in CI #38424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case dependencies are not synchronized between provider.yaml and pyproject.toml, they got regenerated in CI, just to prevent the case we are using old dependencies - using pre-commit script. Normally pre-commit fails when it make changes to files, but in case we are building CI image we run the pre-commit manually as we do not want to initialize all pre-commit environments and in this case we should also sys.exit(1) to fail the image build in this case.
potiuk
force-pushed
the
exit-with-error-when-dependencies-got-updated
branch
from
74d494a to
f31cb92
Compare
Member
Author
hussein-awala
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case dependencies are not synchronized between provider.yaml and pyproject.toml, they got regenerated in CI, just to prevent the case we are using old dependencies - using pre-commit script.
Normally pre-commit fails when it make changes to files, but in case we are building CI image we run the pre-commit manually as we do not want to initialize all pre-commit environments and in this case we should also sys.exit(1) to fail the image build in this case.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.