Chart: Allow AWS ECS Executor

[LipuFei]

Make it possible to use the alpha/experimental AWS ECS Executor with the Helm chart. (link: https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/executors/ecs-executor.html)

The changes are:

1. Add the following executors into the allowed executor values:
   • airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor
   • airflow.providers.amazon.aws.executors.ecs.AwsEcsExecutor
2. Truncate the executor label value to a max of 50 63 characters because Kubernetes doesn't allow a label value with more than 50 63 characters.
3. Updated the Helm chart README.

I've tested this setup and it works. These are the minimum changes I need in the Helm chart.

[jedcunningham]

@LipuFei can you add tests for when this executor is set? Following LocalExecutor is probably a reasonable way to find place where cases should be added.

[o-nikolas]

Putting a request change on this to ensure it doesn't get merged before a fix to shorten the aws module paths (#39093)

[LipuFei]

@LipuFei can you add tests for when this executor is set? Following LocalExecutor is probably a reasonable way to find place where cases should be added.

@jedcunningham I didn't create the AWS executors, so I probably can only create some very basic tests... Maybe @o-nikolas can help here?

[o-nikolas]

Oops, my PR closed this one accidentally, re-opened!

.

[LipuFei]

Hi @eladkal @o-nikolas @jedcunningham , I have updated my changes and the PR description. Could you check it again? Thanks.

[jedcunningham]

Thanks @LipuFei. Can you add tests for this also? Might be worth running around looking at LocalExecutor cases, as that's the most similar from the charts perspective I think.

This test case should be updated as well. Can you harden it (make it fail if supported executors aren't all listed), or simplify it?

I expect we may need some rbac changes as well for these executors? Is that something you've investigated?

[LipuFei]

Thanks @LipuFei. Can you add tests for this also? Might be worth running around looking at LocalExecutor cases, as that's the most similar from the charts perspective I think.

This test case should be updated as well. Can you harden it (make it fail if supported executors aren't all listed), or simplify it?

I expect we may need some rbac changes as well for these executors? Is that something you've investigated?

Hi @jedcunningham , I've updated the tests, including testing the supported executor.

For AWS ECS Executor, there's no need for RBAC changes. I haven't tested the Batch Executor, but I think it works in similar ways.

[jedcunningham]

For rbac I think thinking of this, but looks like we are good there.

[LipuFei]

I've updated this PR. All checks have passed.

From my point of view, this PR is ready for merge 😄 if there's no further comments...