Skip to content

Conversation

@Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Mar 27, 2024

Prohibit to use unsupported DB backends, some of the tests use some never supported, e.g. drill 🙄 or still depend on MsSQL which removed.

Step 1: Found tests not use valid markers
Step 2: Move into integration tests
Step 3: Create follow up task
Step 4: Update: #35442
Step N: Profit


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis added the canary When set on PR running from apache repo - behave as canary run label Mar 27, 2024
@Taragolis Taragolis requested review from eladkal and uranusjr March 27, 2024 10:20
@Taragolis
Copy link
Contributor Author

backend test node
drill tests/providers/apache/drill/operators/test_drill.py::TestDrillOperator::test_drill_operator_single
drill tests/providers/apache/drill/operators/test_drill.py::TestDrillOperator::test_drill_operator_multi
mssql tests/providers/apache/hive/transfers/test_mssql_to_hive.py::TestMsSqlToHiveTransfer::test_type_map_binary
mssql tests/providers/apache/hive/transfers/test_mssql_to_hive.py::TestMsSqlToHiveTransfer::test_type_map_decimal
mssql tests/providers/apache/hive/transfers/test_mssql_to_hive.py::TestMsSqlToHiveTransfer::test_type_map_number
mssql tests/providers/apache/hive/transfers/test_mssql_to_hive.py::TestMsSqlToHiveTransfer::test_type_map_string
mssql tests/providers/apache/hive/transfers/test_mssql_to_hive.py::TestMsSqlToHiveTransfer::test_execute
mssql tests/providers/apache/hive/transfers/test_mssql_to_hive.py::TestMsSqlToHiveTransfer::test_execute_empty_description_field
mssql tests/providers/google/cloud/transfers/test_bigquery_to_mssql.py::TestBigQueryToMsSqlOperator::test_execute_good_request_to_bq
mssql tests/providers/google/cloud/transfers/test_mssql_to_gcs.py::TestMsSqlToGoogleCloudStorageOperator::test_convert_type
mssql tests/providers/google/cloud/transfers/test_mssql_to_gcs.py::TestMsSqlToGoogleCloudStorageOperator::test_init
mssql tests/providers/google/cloud/transfers/test_mssql_to_gcs.py::TestMsSqlToGoogleCloudStorageOperator::test_exec_success_json
mssql tests/providers/google/cloud/transfers/test_mssql_to_gcs.py::TestMsSqlToGoogleCloudStorageOperator::test_file_splitting
mssql tests/providers/google/cloud/transfers/test_mssql_to_gcs.py::TestMsSqlToGoogleCloudStorageOperator::test_schema_file

@potiuk
Copy link
Member

potiuk commented Mar 27, 2024

Who added !!?@$##$# drill as backend :D ???

@Taragolis Taragolis merged commit 279d1f7 into main Mar 27, 2024
@Taragolis Taragolis deleted the unsupported-bakends branch March 27, 2024 16:41
ephraimbuddy pushed a commit that referenced this pull request Apr 2, 2024
* Prohibit to use unsupported DB backends in tests

* Move invalid backends tests into the integration

* Add files to missing unit tests

(cherry picked from commit 279d1f7)
ephraimbuddy pushed a commit that referenced this pull request Apr 2, 2024
* Prohibit to use unsupported DB backends in tests

* Move invalid backends tests into the integration

* Add files to missing unit tests

(cherry picked from commit 279d1f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

canary When set on PR running from apache repo - behave as canary run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants