Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Mar 28, 2024

The workflow for docs building had been moved to a different sub-workflow and it needs secrets in canary build to upload the docs to AWS. This PR adds the secret inheriting to the docs workflow to fix the problem.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The workflow for docs building had been moved to a different
sub-workflow and it needs secrets in canary build to upload the
docs to AWS. This PR adds the secret inheriting to the docs workflow to
fix the problem.
@potiuk potiuk merged commit 85f3b46 into apache:main Mar 28, 2024
@potiuk potiuk deleted the fix-uploading-to-aws-on-docs-build branch March 28, 2024 22:03
@potiuk potiuk added this to the Airflow 2.9.0 milestone Mar 28, 2024
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 31, 2024
ephraimbuddy pushed a commit that referenced this pull request Mar 31, 2024
The workflow for docs building had been moved to a different
sub-workflow and it needs secrets in canary build to upload the
docs to AWS. This PR adds the secret inheriting to the docs workflow to
fix the problem.

(cherry picked from commit 85f3b46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants