Remove google-cloud-aiplatform when tests without pydantic are run#38617
Merged
potiuk merged 1 commit intoapache:mainfrom Mar 29, 2024
Merged
Conversation
The apache#37818 bumped requirement for google-cloud-aiplatform to a version that requires Pydantic so we need to remove it when we are running "no-pydantic" tests. The tests that import it should be skipped when the dependency is removed.
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:google
potiuk
added
the
full tests needed
Taragolis
approved these changes
Mar 29, 2024
jscheffl
approved these changes
Mar 29, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 29, 2024
Turns out that we need to conditionally skip a few more tests in order to make "Pydantic Removed" tests happy after apache#38617
potiuk
added a commit
that referenced
this pull request
Mar 29, 2024
Turns out that we need to conditionally skip a few more tests in order to make "Pydantic Removed" tests happy after #38617
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #37818 bumped requirement for google-cloud-aiplatform to a version that requires Pydantic so we need to remove it when we are running "no-pydantic" tests.
The tests that import it should be skipped
when the dependency is removed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.