Rename allowed_filter_attrs to allowed_sort_attrs
#38626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the attrs we allow sorting on, not filtering on.
jedcunningham
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:API
eladkal
approved these changes
Mar 29, 2024
dirrao
approved these changes
Mar 30, 2024
hussein-awala
approved these changes
Mar 30, 2024
jedcunningham
added
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 31, 2024
These are the attrs we allow sorting on, not filtering on. (cherry picked from commit e700f41)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the attrs we allow sorting on, not filtering on.