Fix ti.start_date is set even in pre-running state by ti.set_state #38631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kzosabe
commented
Mar 30, 2024
| [ | ||
| (TaskInstanceState.SCHEDULED, TaskInstanceState.QUEUED, False), | ||
| (TaskInstanceState.SCHEDULED, TaskInstanceState.RUNNING, True), | ||
| (TaskInstanceState.SCHEDULED, TaskInstanceState.SUCCESS, True), |
Author
There was a problem hiding this comment.
We can also add test cases like below, but currently they are not passed.
If we get concensus about state matrix in #38632 , I can try to resolve it.
(TaskInstanceState.RUNNING, TaskInstanceState.SCHEDULED, False),
(TaskInstanceState.RUNNING, TaskInstanceState.QUEUED, False),
(TaskInstanceState.RUNNING, TaskInstanceState.SUCCESS, True),
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #38632 and #34771 (comment)
From the discussion of above PR, ti.start_date is normally set when ti transitions to the RUNNING state.
But the current ti.set_state method has set start_date even though the state is prior to RUNNING.
This creates an unstable situation where start_date is present in SCHEDULED and QUEUED ti generated by backfilling, but not in ti that is not.
This is an unnatural behavior for ti's state transitions, so we try to fix it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.