Rename build arg for upgrade-to-newer-dependencies #38637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:production-image
potiuk
force-pushed
the
rename-docker-build-param-to-include-hash
branch
from
bb720d0 to
345d312
Compare
aritra24
approved these changes
Mar 30, 2024
potiuk
force-pushed
the
rename-docker-build-param-to-include-hash
branch
from
345d312 to
778ac5a
Compare
Lee-W
reviewed
Mar 31, 2024
potiuk
force-pushed
the
rename-docker-build-param-to-include-hash
branch
3 times, most recently
from
57a5743 to
504a67e
Compare
potiuk
force-pushed
the
rename-docker-build-param-to-include-hash
branch
from
504a67e to
eb98b6d
Compare
hussein-awala
approved these changes
Apr 1, 2024
The "UPGRADE_TO_NEWER_DEPENDENCIES" build arg was a bit misleading as it was not a true/false value but rather "random hash"/"false". This PR makes it a bit more explicit: * the arg is named UPGRADE_INVALIDATION_STRING now * it's default is "" not false and all conditions are set to check for != or == "". The inputs/outputs in CI job remain as they were - "true/false" but this PR makes it clearer.
potiuk
force-pushed
the
rename-docker-build-param-to-include-hash
branch
from
eb98b6d to
8f19358
Compare
Member
Author
|
I shortened the name a bit :) |
potiuk
changed the title
eladkal
approved these changes
Apr 2, 2024
aritra24
approved these changes
Apr 2, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 2, 2024
The "UPGRADE_TO_NEWER_DEPENDENCIES" build arg was a bit misleading as it was not a true/false value but rather "random hash"/"false". This PR makes it a bit more explicit: * the arg is named UPGRADE_INVALIDATION_STRING now * it's default is "" not false and all conditions are set to check for != or == "". The inputs/outputs in CI job remain as they were - "true/false" but this PR makes it clearer. (cherry picked from commit 1934c8b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "UPGRADE_TO_NEWER_DEPENDENCIES" build arg was a bit misleading
as it was not a true/false value but rather "random hash"/"false".
This PR makes it a bit more explicit:
for != or == "".
The inputs/outputs in CI job remain as they were - "true/false" but
this PR makes it clearer.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.