Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

related #38250

Introducing --latest flag that gets the realistic values for helm charts from the https://airflow.apache.org/_gen/packages-metadata.json and compares to latest state of HEAD.

Example:

➜  airflow git:(latestHelm) ✗ breeze release-management generate-issue-content-helm-chart --limit-pr-count 10 --latest --verbose
/Users/adesai/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/urllib3/__init__.py:34: NotOpenSSLWarning: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 2.8.3'. See: https://github.com/urllib3/urllib3/issues/3020
  warnings.warn(

 Latest stable version of helm chart is 1.13.1


Environment variable VERSION not set, setting current release version as 'HEAD' for helm chart release

/Users/adesai/Documents/OSS/airflow/dev/breeze/src/airflow_breeze/commands /Users/adesai/Documents/OSS/airflow
Command to run: 'git log --pretty=format:%H %h %cd %s --date=short helm-chart/1.13.1...HEAD -- chart/'
Retrieving PR#38510: https://github.com/apache/airflow/pull/38510
Retrieving PR#38478: https://github.com/apache/airflow/pull/38478
Retrieving 10 PRs  ━━━━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━  10% -:--:--

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajesh
Copy link
Contributor Author

@potiuk the next step in the direction for making this command cleaner.

@amoghrajesh amoghrajesh added canary When set on PR running from apache repo - behave as canary run default versions only When assigned to PR - only default python version is used for CI tests labels Apr 1, 2024
@amoghrajesh
Copy link
Contributor Author

Random failure, retriggered now.
@potiuk BTW, the job runs well: https://github.com/apache/airflow/actions/runs/8504852198/job/23292475501?pr=38648

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool :)

@amoghrajesh amoghrajesh requested a review from potiuk April 1, 2024 09:08
@potiuk potiuk merged commit 1cac59e into apache:main Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools canary When set on PR running from apache repo - behave as canary run default versions only When assigned to PR - only default python version is used for CI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants