remove display of param from the UI #38660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
added
the
type:misc/internal
hussein-awala
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
potiuk
approved these changes
Apr 1, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 2, 2024
(cherry picked from commit e20a710)
Contributor
|
|
Member
|
Ah - so does it need to be displayed ? |
Contributor
Yes, but it's a bit broken. So I can work on a real fix for this |
Member
|
👀 |
Member
Author
Waiting for your PR to understand why displaying it is needed in some cases. |
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 2, 2024
(cherry picked from commit e20a710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displaying the root param in the UI was added in 2015 for some reason, but after checking the current usage, I believe it is completely useless:
http://localhost:28080/dags/dag_1/calendar?root=some%20message