OpenAI Chat & Assistant hook functions #38736
Conversation
nathadfield
force-pushed
the
openai_hooks
branch
from
8e88d14 to
fb39756
Compare
kaxil
requested review from
Lee-W,
pankajkoti and
utkarsharma2
and removed request for
pankajkoti and
utkarsharma2
nathadfield
force-pushed
the
openai_hooks
branch
7 times, most recently
from
4d9977a to
9b67e5c
Compare
nathadfield
changed the title
nathadfield
force-pushed
the
openai_hooks
branch
from
9b67e5c to
9796456
Compare
nathadfield
force-pushed
the
openai_hooks
branch
3 times, most recently
from
33248aa to
8d42b77
Compare
|
I'd love a review on this when someone gets an opportunity. Thanks! |
nathadfield
force-pushed
the
openai_hooks
branch
from
5c2a783 to
faaa2d2
Compare
|
Excellent and timely addition. I was just struggling to get openai chat completions to work straight from within pythonoperator, only to silently hang. Looking forward to seeing this implemented |
nathadfield
force-pushed
the
openai_hooks
branch
from
faaa2d2 to
6fbbd5e
Compare
|
One failed test here but I don't think it's anything to do with my changes. |
Just retrigger it. Let's see how it works |
nathadfield
force-pushed
the
openai_hooks
branch
from
6fbbd5e to
9b60062
Compare
|
I rebased which ran the checks again but it's now failing with a different error but still not connected to my changes. How else can I retrigger the checks? |
nathadfield
force-pushed
the
openai_hooks
branch
2 times, most recently
from
0063d3c to
4e1a9e4
Compare
|
@Lee-W I keep rebasing and rerunning but some unrelated tests always seem to fail. Any suggestions? |
|
Looks like network issue 🤔 let me try again. if it still fails, I'll take a deeper look |
You seem to have the magic touch! |
|
Just looking for someone to give it a 👍 now. |
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Overall, it looks good. Left a few nitpicks. But would like have @utkarsharma2 to take another look to ensure I did not miss anything crucial 🙂
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
nathadfield
force-pushed
the
openai_hooks
branch
from
4e1a9e4 to
5c95acf
Compare
|
@Lee-W No worries. Thanks for the input. @utkarsharma2 It'd be great to get any more thoughts from you. |
|
Is someone able to merge this soon then? |
|
I'm planning on merging this one later today. Please let me know if anyone want to take a deeper look. |
5 participants
Adding a set of additional hook functions for the OpenAI provider that deal with interactions between some of the Chat and Assistants API endpoints.