Skip to content

Conversation

@moritzsanne
Copy link
Contributor

closes: #38959


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Apr 12, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 12, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@moritzsanne moritzsanne requested a review from eladkal April 12, 2024 13:49
@eladkal
Copy link
Contributor

eladkal commented Apr 12, 2024

can you add unit test to cover this change?

@moritzsanne moritzsanne force-pushed the glueJobOperatprReplacesScriptFile branch from 9c194f3 to 175f368 Compare April 13, 2024 06:50
@moritzsanne
Copy link
Contributor Author

moritzsanne commented Apr 13, 2024

Hey, thanks for reviewing this so quickly. I've rebased my branch using the rebase button in github after your reviews. I am unsure if this was the right thing to do in this case. I hope this doesn't cause any confusion in the commit history. Let me know if you need anything else from me to get this merged.

Enjoy your weekend!

@eladkal eladkal merged commit d946d7b into apache:main Apr 13, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 13, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GlueJobOperator with local script location fails on consecutive runs

3 participants