Partially enable B028 rule: no-explicit-stacklevel
#39000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirrao
approved these changes
Apr 14, 2024
Taragolis
added
the
changelog:skip
potiuk
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially resolve in #36831
However I forget/do not have a time to resolve other cases and additional
warnings.warnwithout explicitstacklevelwas added unfortunetly. For prevent add new ones which easily could be missed during code reviews, better enable it and created follow up task for resolve existed cases.In most cases
stacklevel=2is more suitable it will refers to the code which invoke this part but it can't be set blindly because it could be additionaly wraps.With default
stacklevel=1it refers to the line with warnings.warn, see: https://docs.astral.sh/ruff/rules/no-explicit-stacklevel/^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.