-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Bump CNCF K8S provider dependency version in Google provider #39030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CNCF K8S provider dependency version in Google provider #39030
Conversation
@eladkal looks like 10.17.0 of the Google provider won't work |
@pankajkoti with your question. Now when you are mentioning it - and since it is only one provider - probably a better approach is to try/catch the specific import error and raise |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained in the comment since this is one Operator only - better way is to turn the import error into OptionalProviderFeature with explanation that 8.1.0 of cncf.kubernetes is needed for that
Yes I also wanted to raise this. We should use |
Removing stale review based on latest comment from Jarek
|
closing in favour of #39036 |

PR #37793 introduced
KubernetesDeleteJobOperatorin the latest release8.1.0of thecncf-kubernetesprovider, which is also a dependencyfor the latest release of the
googleprovider10.17.0.This PR bumps the
cncf-kubernetesprovider dependency versionto a minimum of
8.1.0for thegoogleprovider.It appears that
googleprovider10.17.0won't together withcncf-kubernetesprovider<8.1.0. So we would also need todiscuss what could be done for the released google provider.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.