-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Enable none default ftp port #39048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable none default ftp port #39048
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Is this the failed check? But it is ftp without TLS or ssl, we do have this scenario. |
dirrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the test case for the current scenario?
kerlion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, have fixed it.
|
This probably should have a test? |
|
Hi, is this ready for merging, anything else need I to do? |
Have you seen this @kerlion ?
|
eladkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add unit test to cover this change?
Sorry, I do know know how to add unit test, but I tested it in my PROD env. |
|
Suppressed by #39465 |
When I use ftp hook in my airflow env, it will wait till timeout when I use a none-standard ftp port. I fixed it by modify the source code. It has run for 2+ months without issue.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.