Skip to content

Conversation

@kerlion
Copy link

@kerlion kerlion commented Apr 16, 2024


When I use ftp hook in my airflow env, it will wait till timeout when I use a none-standard ftp port. I fixed it by modify the source code. It has run for 2+ months without issue.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 16, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@kerlion
Copy link
Author

kerlion commented Apr 16, 2024

Is this the failed check?
Issue: [B321:blacklist] FTP-related functions are being called. FTP is considered insecure. Use SSH/SFTP/SCP or some other encrypted protocol.

But it is ftp without TLS or ssl, we do have this scenario.

@kerlion kerlion changed the title Enable none default ftp prot Enable none default ftp port Apr 16, 2024
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the test case for the current scenario?

Copy link
Author

@kerlion kerlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, have fixed it.

@kerlion kerlion requested a review from hussein-awala April 18, 2024 08:28
@kerlion kerlion requested a review from dirrao April 19, 2024 00:35
@uranusjr
Copy link
Member

This probably should have a test?

@kerlion
Copy link
Author

kerlion commented Apr 22, 2024

Hi, is this ready for merging, anything else need I to do?

@potiuk
Copy link
Member

potiuk commented Apr 22, 2024

Hi, is this ready for merging, anything else need I to do?

Have you seen this @kerlion ?

This probably should have a test?

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add unit test to cover this change?

@kerlion
Copy link
Author

kerlion commented Apr 28, 2024

Can you please add unit test to cover this change?

Sorry, I do know know how to add unit test, but I tested it in my PROD env.

@eladkal
Copy link
Contributor

eladkal commented May 27, 2024

Suppressed by #39465

@eladkal eladkal closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants